fix for #18839: place.around() now works correct in fullscreen mode

[yurijmikhalevich]

https://bugs.dojotoolkit.org/ticket/18839

[jquerybot]

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

---

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

[yurijmikhalevich]

It also requires similar css-rule for popups to be displayed correctly over fullscreen divs. It is not in the commit, because I am not sure, whether applying this globally will break something in dojo or not. It looks like it shouldn't.

.dijitPopup {
    z-index: 2147483647 !important;
}

[wkeese]

OK. Thanks for the patch. As I wrote in the ticket, if you can include a test case for when the current code is failing I'll look at it.

One other issue with your patch though is that https://developer.mozilla.org/en-US/docs/Web/API/Document/mozFullScreen says:

Note that the draft specification of the fullscreen API does not include a document.fullscreen attribute, and instead suggests checking whether document.fullscreenElement is non-null to determine whether the browser is in fullscreen mode. Using document.fullscreenElement to dertermine whether the browser is in fullscreen mode is recommend.

You seem to be violating that rule. (But again, I don't even understand what problem you are trying to fix, since the code seems to work in fullscreen mode for me already.)

[yurijmikhalevich]

@wkeese

Using document.fullscreenElement to dertermine whether the browser is in fullscreen mode is recommend.

I don't see how I am violating the rule. I am using document.fullscreenElement as the rule and examples says.

include a test case for when the current code is failing I'll look at it.

I will be able to send you an example on Tuesday.

Basically, this code will fail, if there is an aroud div inside a div in fullscreen mode with geometry like {1800, 732, 32, 32}, but one of fullscreen div's parents has {width: 800px, height: 600px} and located somewhere left on the page. This results in negative width and height anchor values after computing positions of visible parts of the anchor.

[wkeese]

OK, I look forward to the test case.

About the MDN page, I was just worried because the MDN page says to "check whether document.fullscreenElement is non-null", but you are actually accessing the value. But I suppose that's OK.

[yurijmikhalevich]

I was just worried because the MDN page says to "check whether document.fullscreenElement is non-null"

It looks for me that you took this wrong. It says, that there is no document.fullscreen (which should be a boolean indicating whether fullscreen is on/off) in standard. So it is better to check whether there is something or not in the document.fullscreenElement field if you need to check whether fullscreen mode is on/off. But, document.fullscreenElement is more than just boolean, it returns an element that is currently being presented in fullscreen mode. (https://developer.mozilla.org/en-US/docs/Web/API/Document/mozFullScreenElement)

So, the paragraph just recommends us to not use document.fullscreen, and I am not using it at all.

[yurijmikhalevich]

There is a bug demo source: https://pastebin.mozilla.org/8870456

Note, that it is reproducible in Chrome and in Opera, but not in FF.

http://prntscr.com/b2e27a
http://prntscr.com/b2e2bf

[wkeese]

That https://pastebin.mozilla.org/8870456 example link doesn't work [anymore]. It would actually be ideal if you could add an automated test case to the pull request. Otherwise someone else will have to do it before accepting the PR.

You mentioned creating a CSS rule to set zIndex on dijitPopup nodes... but the popups' zIndex is currently controlled by dijit/popup. It starts at the _beginZIndex setting and then is incremented for each nested popup. If I set zIndex to 2147483647 (2^31 - 1) to start with, then it seems like I can't increment it for nested popups.

[dylans]

@39dotyt would love to finally land this, but still waiting on an automated test.

[dylans]

Needs automated test per comments.

[msssk]

Closing this for extended inactivity and lack of a test case. Running Dijit's existing test file (dijit/tests/place.html) in full screen does not reveal any deficiencies.