[cla] Update FilterDefDialog.js #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keypress event should only be used when the pressed key also results in a character, such as the letters A-Z and so on. The Enter-key should trigger it.
|
My enhanced grid running on dojo 1.10 work like expected now. |
|
Hi @Adam16 I don't see a CLA on file for you, could you submit one please? ( http://dojofoundation.org/about/claForm ) Also, while EnhancedGrid is deprecated, this seems simple enough that I'll commit it once your CLA is on file. |
dylans
changed the title
dylans
changed the title
|
Thanks! Closed via bf7b7af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keypress event should only be used when the pressed key also results in a character, such as the letters A-Z and so on. The Enter-key should trigger it.