Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket reconnect #158

Closed
wants to merge 2 commits into from
Closed

Conversation

neonstalwart
Copy link
Contributor

this PR makes the following changes:

  • prevents failures caused when not providing options for reconnect
  • uses options.reconnectTime as the timeout for checkForOpen

@Kagetsume since you seem to also have an interest in this module, you want to review my changes for me?

@neonstalwart
Copy link
Contributor Author

hold on this... i think i've broken the backoff - will comment again when i've fixed it.

@neonstalwart
Copy link
Contributor Author

ok, should be good now

@dylans dylans added this to the 1.11 milestone Mar 25, 2015
@dylans
Copy link
Member

dylans commented Apr 19, 2015

Thanks for the fix, closed via 5a7969c

@dylans dylans closed this Apr 19, 2015
@neonstalwart neonstalwart deleted the socket-reconnect branch May 11, 2015 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants