Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow top level registry items in the renderer #139

Merged
merged 3 commits into from Nov 22, 2018

Conversation

@agubler
Copy link
Member

commented Oct 15, 2018

Type: feature

The following has been addressed in the PR:

Description:

Registry items are resolved in WidgetBase, which means to enable using a registry item at the top level we need to wrap w() nodes (as well as v() nodes) with a wrapping widget.

The top level projector invalidation needs to ignore the wrapper, and pick the consumers widget.

agubler added 3 commits Oct 15, 2018

@agubler agubler merged commit 8bc723d into dojo:master Nov 22, 2018

4 checks passed

codecov/patch 100% of diff hit (target 97.05%)
Details
codecov/project 97.05% (+<.01%) compared to bef2abe
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.