Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TS 3.8 #719

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Upgrade to TS 3.8 #719

merged 4 commits into from
Apr 8, 2020

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Apr 7, 2020

Type: feature

The following has been addressed in the PR:

Description:

Resolves #718

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 690a0e6:

Sandbox Source
cool-jackson-8983q Configuration

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #719 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   97.76%   97.78%   +0.02%     
==========================================
  Files         120      121       +1     
  Lines        6974     7052      +78     
  Branches     1585     1603      +18     
==========================================
+ Hits         6818     6896      +78     
  Misses        156      156              
Impacted Files Coverage Δ
src/core/middleware/focus.ts 100.00% <ø> (ø)
src/shim/array.ts 100.00% <ø> (ø)
src/shim/object.ts 97.82% <ø> (ø)
src/core/middleware/data.ts 100.00% <100.00%> (ø)
src/core/middleware/theme.ts 95.78% <100.00%> (ø)
src/stores/process.ts 99.33% <100.00%> (ø)
src/testing/mocks/middleware/focus.ts 100.00% <100.00%> (ø)
src/routing/Router.ts 100.00% <0.00%> (ø)
src/routing/Outlet.ts
src/routing/Route.ts 71.42% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719e088...690a0e6. Read the comment docs.

Copy link
Member

@agubler agubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, doesn't look overly complicated so far.

src/stores/process.ts Outdated Show resolved Hide resolved
package.json Outdated
@@ -86,7 +86,7 @@
"rimraf": "~2.6.2",
"selenium-webdriver": "3.6.0",
"sinon": "~4.1.3",
"typescript": "3.4.5"
"typescript": "3.8.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change the version, we are mostly trying to make the package forwards compatible. Is that possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that was just my misunderstanding. I've reverted the package version, still builds fine against 3.4.5

@maier49 maier49 marked this pull request as ready for review April 7, 2020 17:36
@maier49
Copy link
Contributor Author

maier49 commented Apr 7, 2020

This worked with the next version of TypeScript as well with no further changes needed than for 3.8

@maier49 maier49 merged commit 74e5e4e into dojo:master Apr 8, 2020
@maier49 maier49 deleted the ts-3.8 branch April 8, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TypeScript 3.8.x and potentially 3.9.x
3 participants