Support setting properties on named children that are a render result for assertions#854
Merged
agubler merged 2 commits intodojo:masterfrom Oct 22, 2020
Merged
Support setting properties on named children that are a render result for assertions#854agubler merged 2 commits intodojo:masterfrom
agubler merged 2 commits intodojo:masterfrom
Conversation
matt-gadd
approved these changes
Oct 22, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da502ad:
|
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 94.84% 94.83% -0.02%
==========================================
Files 127 127
Lines 8046 8049 +3
Branches 1868 1870 +2
==========================================
+ Hits 7631 7633 +2
- Misses 415 416 +1
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Oct 22, 2020
rorticus
pushed a commit
to rorticus/framework
that referenced
this pull request
Oct 22, 2020
… for assertions (dojo#854) * failing unit tests * find named children that are render results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Adds support to find nodes in named children that are render results.
Resolves #853