Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending API to expose the state of asynchronous icache setters #862

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 25, 2020

Type: feature

The following has been addressed in the PR:

Description:

In order to be able to determine the status of an async icache.set/icache.getOrSet this new API, .pending returns if the promise is still unresolved.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3bcaa6f:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #862 (3bcaa6f) into master (e74d23b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         127      127           
  Lines        8084     8087    +3     
  Branches     1884     1885    +1     
=======================================
+ Hits         7657     7660    +3     
  Misses        427      427           
Impacted Files Coverage Δ
src/core/middleware/icache.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74d23b...3bcaa6f. Read the comment docs.

@agubler agubler merged commit 59647b8 into dojo:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants