Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use callback format with provided global #66

Closed
wants to merge 1 commit into from

Conversation

pottedmeat
Copy link
Contributor

As part of #270, using the global variable with strict mode and CSP unsafe-eval enforced means we need to retrieve the global object manually. dojo.js has been updated to retrieve this object and supports a function callback to its first argument to which it will pass this global object.

@dylans dylans added this to the 1.12.3 milestone Aug 31, 2017
@dylans
Copy link
Member

dylans commented Sep 19, 2017

Thanks! Closed via 5d624ec. Backported as ef6ae23 (1.12), 57854aa (1.11), and 119fd1e (1.10).

@dylans dylans closed this Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants