This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Type theme property #612
Merged
Type theme property #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
The
themeproperty is typed asanywhen it could be typed as an index. This would prevent people from accidentally assigning themes that are not valid. I tried to typeinjectedThemebut there appears to be, likely, a code logic issue in thatThemeable._themeis typed asClassNamesbut there is also a comparison oftheme !== injectedThemein the code, which means that we are likely mis-handling something somewhere, but we should try to typeinjectedThemeandextraClasseswith something that is more narrow thananyas it is just too prone to downstream errors.