This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Add support for core properties #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
reviewed
Sep 6, 2017
src/WidgetBase.ts
Outdated
| } | ||
| } | ||
|
|
||
| protected getCoreProperties(properties: any): CoreProperties { |
There was a problem hiding this comment.
do you think this should be double underscored?
There was a problem hiding this comment.
That's a reasonable suggestion as we do not want people to override this function, even if it is just protected
matt-gadd
reviewed
Sep 6, 2017
| if (node.coreProperties.bind === undefined) { | ||
| node.coreProperties.bind = this; | ||
| } | ||
| node.coreProperties.defaultRegistry = defaultRegistry; |
There was a problem hiding this comment.
do you think we should make coreProperties a symbol? or bad idea?
There was a problem hiding this comment.
I'm not sure what it would give?
There was a problem hiding this comment.
i guess it would make it transparent to the end user. but i think we agreed that didn't matter anyway.
matt-gadd
approved these changes
Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Adds support for
corePropertiesand processes them before the normally__setProperties__phase.Resolves #658