-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about sozo arguments priorities #176 #269
Add information about sozo arguments priorities #176 #269
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello @glihm 👋 could you check If this is going on good path? thanks! Discord: roloxworld |
hello @RolandoDrRobot, thank you for the contribution. I will review this ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR here @RolandoDrRobot! We may also show some examples on how to use a keystore
file instead of private key for instance. To ensure users know about those alternatives.
- `account(provider, env_metadata)`: Creates a StarkNet account using the specified options. Takes into account the configuration priorities to determine the account address and other settings. | ||
- `account_address(env_metadata)`: Returns the StarkNet account address. Takes into account the configuration priorities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't those inside the sozo code? Not sure if a sozo user should know about this technical specificity. Or what was the idea behind this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just documenting everything I saw in the code file https://github.com/lambda-0x/dojo/blob/9bf0a0894eadb7052fab586886ee02ba6beae351/crates/sozo/src/commands/options/account.rs but you are right, people may not need this, removing It
@@ -35,3 +35,9 @@ The configuration system follows the following priority order: | |||
```bash | |||
sozo --rpc-url http://localhost:7474/ | |||
``` | |||
|
|||
### Use a keystore file for account configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? what u were meaning? otherwise could you provide me an example or where to get It? thanks @glihm @lambda-0x
@lambda-0x @glihm Hello guys 👋 is this still active? let me know If wanna add something else to PR |
Sorry for the delay man the notification went of my radar, appreciate your ping here. @lambda-0x has some feedback he will made and then ready to merge. |
@glihm thank you 🙏 |
eee32c4
to
4c1748a
Compare
5f92f87
to
339b1d5
Compare
@RolandoDrRobot sorry for the delay on this, and thank you for your contribution! |
This the issue #176
Sozo is being reworked to have these priorities:
We may add a section on that on the book once this PR is merged dojoengine/dojo#1405 to bring better understanding for the user to the possibilities around configurations.