tests: refactor and add new tests

[lambda-0x]

follow up: #1358

[lambda-0x]

@kariy signer method returns a LocalWallet which doesn't provide access to its inner types.

so to verify if two LocalWallets are same (in the test) we would need to use async methods which would require making tests more complicated.

any other ideas to test the signer method?

[glihm]

so to verify if two LocalWallets are same (in the test) we would need to use async methods which would require making tests more complicated.

Without adding more complexity, you may try to use a tokio::test instead where you can use async functions. Or is there an other restriction I'm not seeing here?

[lambda-0x]

so to verify if two LocalWallets are same (in the test) we would need to use async methods which would require making tests more complicated.

Without adding more complexity, you may try to use a tokio::test instead where you can use async functions. Or is there an other restriction I'm not seeing here?

Yeah I think that should probably work but I was wondering if there is any better way to do it

[kariy]

any other ideas to test the signer method?

Yeah, as @glihm mentioned, tokio::test is fine.

[glihm]

Good work on that!

May worth ordering the test by tested field for easier navigation and verification of which test is here.

[lambda-0x]

removed this require so that when passing keystore_password we can still get keystore_path from environment metadata

[lambda-0x]

removed to be consistent with the behaviour of keystore.

user can specify account_address in Scarb.toml and provide private_key from commandline.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36e5853) 67.13% compared to head (84b20dc) 67.51%.
Report is 2 commits behind head on main.

❗ Current head 84b20dc differs from pull request most recent head 9bf0a08. Consider uploading reports for the commit 9bf0a08 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   67.13%   67.51%   +0.37%     
==========================================
  Files         231      231              
  Lines       20858    21023     +165     
==========================================
+ Hits        14003    14193     +190     
+ Misses       6855     6830      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.