Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utf8 character set as default #62

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Use utf8 character set as default #62

merged 1 commit into from
Oct 28, 2016

Conversation

srna
Copy link
Contributor

@srna srna commented Oct 10, 2016

I believe it is reasonable to use utf8 as the default charset in MySQL databases. This PR makes the dokku plugin use this charset as default.

@josegonzalez
Copy link
Member

Fuck yeah utf-8!

How does this work with databases where:

  • the database is created and is running
  • the container is stopped and removed
  • the plugin is updated to this version with utf8 defaults
  • the container is started again

@josegonzalez josegonzalez mentioned this pull request Oct 10, 2016
@aminotsukasa
Copy link

It is simple to use utf-8 charset.

@srna
Copy link
Contributor Author

srna commented Oct 16, 2016

@josegonzalez, I think it only affects database creation, so it doesn't have effect on other states of the database/container lifecycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants