Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character set #61

Closed
srna opened this issue Sep 20, 2016 · 3 comments
Closed

Character set #61

srna opened this issue Sep 20, 2016 · 3 comments

Comments

@srna
Copy link
Contributor

srna commented Sep 20, 2016

It would be nice to be able to specify character set and collation. Even better would be to being able to specify it as a global default for server and separately by instance. Or at least use utf8 & utf8_general_ci as hard-wired default, as most of the apps use it.

@aminotsukasa
Copy link

aminotsukasa commented Oct 5, 2016

Hi srna
I have a same problem for japanese user.
I create a branch with mysqld additional_mysqld_config function.

this is a usage sample code changing mysqld character_set_server.

$ export ADDITIONAL_MYSQLD_CONF="[mysqld]\ncharacter-set-server=utf8\ncollation-server=utf8_general_ci
$ dokku mysql:create japanese-test
$ cat  /var/lib/dokku/services/mysql/japanese-test/config/additional_mysqld_config.cnf
[mysqld]
character-set-server=utf8
collation-server=utf8_general_ci

$ dokku mysql:enter japanese-test mysql -u mysql -p japanese-test -e "SHOW VARIABLES LIKE  'char%';"
+--------------------------+----------------------------+
| Variable_name            | Value                      |
+--------------------------+----------------------------+
| character_set_client     | latin1                     |
| character_set_connection | latin1                     |
| character_set_database   | utf8                       |
| character_set_filesystem | binary                     |
| character_set_results    | latin1                     |
| character_set_server     | utf8                       |
| character_set_system     | utf8                       |
| character_sets_dir       | /usr/share/mysql/charsets/ |
+--------------------------+----------------------------+

source code is here .
https://github.com/aminotsukasa/dokku-mysql/tree/option_mysql_conf

josegonzalez
Can I send pull request with this branch?

@srna
Copy link
Contributor Author

srna commented Oct 10, 2016

Hi aminotsukasa

Thank you so much for this patch. I myself made a patch inspired by your, having just utf8 as the charset. I made also a pull request, but it is not likely that they accept it. Serves me well, though.

My repo is https://github.com/srna/dokku-mysql

Thanks.
Tomas

@josegonzalez
Copy link
Member

#62 is up, and closes this. I have a clarifying question, otherwise it'll def be merged in. It is a pretty sane default imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants