Hitting an undefined app URL displays the 'wrong' app

[rnorth]

e.g. if you only have one app deployed at foo.dokku.me and for any reason try to hit bar.dokku.me in a browser, you'll see the foo app. While pretty minor, it might be good to display a No Such App page like heroku does, to avoid confusion.

Looks like nginx is routing to either the first or the last servername it knows of if no matching servernames are found. We could fix this by adding a fallthrough server block to the nginx dokku.conf (e.g. with server_name _)

[Kyso]

This is actually quite simple, Dokku includes itself before the /etc/nginx/sites-enabled. Just swap those two wildcard includes at the bottom of /etc/nginx/nginx.conf and you'll be sweet to go for setting your default vhost.

EDIT:
That is, swap both the conf.d line and the sites-enabled include lines,

include /etc/nginx/conf.d/*.conf;
include /etc/nginx/sites-enabled/*;

to

include /etc/nginx/sites-enabled/*;
include /etc/nginx/conf.d/*.conf;

[progrium]

So we'll leave this to documentation / configuration?

[Kyso]

To be honest? Yes, it's just an oddity in nginx.
On Jun 16, 2013 3:35 PM, "Jeff Lindsay" notifications@github.com wrote:

So we'll leave this to documentation / configuration?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-19517615
.

[progrium]

I agree. Less software to write, the better! @rnorth is that satisfactory?

[rnorth]

What about placing dokku.conf in sites-enabled in the first place? Does that strain the metaphor of a 'site' too far? ;)

Otherwise, I'm totally fine with the suggestion of documentation - totally agree with the principle of less code!

[progrium]

Let's close for now and if it keeps nagging or other people complain we'll think about it then. I put it on the wiki for now under Recipes: https://github.com/progrium/dokku/wiki/Recipes

If anybody has proto docs or snippets or anything, feel free to put on the wiki. Eventually they might find their way into more official docs.