Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ps:restore to start applications which weren't manually stopped #1613

Merged
merged 1 commit into from
Oct 28, 2015
Merged

add ps:restore to start applications which weren't manually stopped #1613

merged 1 commit into from
Oct 28, 2015

Conversation

kdomanski
Copy link
Contributor

Allows e.g. restarting previously running apps on reboot.

depends on #1610

@michaelshobbs
Copy link
Member

Hmm, this is interesting. We could potentially use this in /etc/init/dokku-redeploy.conf instead of ps:restartall. @josegonzalez thoughts?

@josegonzalez
Copy link
Member

@kdomanski we merged your post-stop plugin trigger, so can you remove that from this pr?

@michaelshobbs how would that work?

@michaelshobbs
Copy link
Member

@josegonzalez sed -i 's/ps:restartall/ps:restore' /etc/init/dokku-redeploy.conf
because ps:restore is a filtered list of apps to restart instead of all apps i think this might make more sense to use to start apps on boot. maybe i'm missing something though.

EDIT: @kdomanski how do you use this functionality?

@kdomanski
Copy link
Contributor Author

@michaelshobbs
dokku ps:restore as a oneshot supervisord task inside a container.
Before we used a systemd unit like this.

@josegonzalez
Copy link
Member

@michaelshobbs that might work. Any objections against this PR as is? We can test the reboot functionality separately from this.

@josegonzalez
Copy link
Member

@michaelshobbs Can we merge as is and have a separate pr that redoes our restart strategy?

@michaelshobbs
Copy link
Member

yes

josegonzalez added a commit that referenced this pull request Oct 28, 2015
add ps:restore to start applications which weren't manually stopped
@josegonzalez josegonzalez merged commit f13796f into dokku:master Oct 28, 2015
@kdomanski kdomanski deleted the restore branch October 28, 2015 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants