Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter restart policies from exec-app-json containers #2060

Merged
merged 1 commit into from Apr 1, 2016

Conversation

michaelshobbs
Copy link
Member

No description provided.

@josegonzalez
Copy link
Member

Is it possible to test this?

@michaelshobbs
Copy link
Member Author

I tested locally. You think we need a unit test?

@josegonzalez
Copy link
Member

Maybe? I vaguely recall us saying there were other args that couldn't be applied to certain phases. I'm fine with merging either way.

@michaelshobbs
Copy link
Member Author

We have that other filtering in place in the docker-options plugin itself. This is sort of a special edge case (aren't they all?!) that's specific to restart policies and the pre/post deploy containers. i.e. we want to include the deploy docker-options because we want that container to look as much like the actual deployed container as possible but the restart policy doesn't make sense to include.

@josegonzalez
Copy link
Member

Gotcha. Again, works for me if you feel it's good to merge :)

@michaelshobbs
Copy link
Member Author

I reserve the right to add a test in the future. (maintainers prerogative 😉)

@michaelshobbs michaelshobbs self-assigned this Mar 31, 2016
@josegonzalez josegonzalez merged commit 9da47d8 into master Apr 1, 2016
@josegonzalez josegonzalez deleted the mh-filter-restart-exec-json branch April 1, 2016 17:13
@josegonzalez josegonzalez changed the title filter restart policies from exec-app-json containers Filter restart policies from exec-app-json containers Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants