Quiet output for git-related commands #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
commented
Apr 10, 2017
| @@ -60,7 +60,7 @@ git_build_app_repo() { | |||
| suppress_output git submodule update --init --recursive | |||
| find . -name .git -prune -exec rm -rf {} \; > /dev/null | |||
|
|
|||
| plugn trigger post-extract "$APP" "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" "$REV" | |||
| plugn trigger post-extract "$APP" "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" "$REV" | sed -u "s/^/"$'\e[1G'"/" | |||
There was a problem hiding this comment.
This removes the remote: prefix that we normally remove when it's just triggered by pre-receive-app.
josegonzalez
commented
Apr 10, 2017
| @@ -107,7 +107,7 @@ git_hook_cmd() { | |||
| local APP="$2" | |||
| local DOKKU_DEPLOY_BRANCH="$(git_deploy_branch "$APP")" | |||
|
|
|||
| if ! git check-ref-format --branch "$DOKKU_DEPLOY_BRANCH" 2> /dev/null; then | |||
| if ! git check-ref-format --branch "$DOKKU_DEPLOY_BRANCH" > /dev/null 2>&1; then | |||
There was a problem hiding this comment.
This outputs the branch name, though we actually don't care about the output, so long as the command returns zero (meaning its a valid branch name).
michaelshobbs
approved these changes
Apr 10, 2017
josegonzalez
added a commit
that referenced
this pull request
Apr 11, 2017
# History ## 0.9.4 ### Documentation - #2710: @josegonzalez Quiet output for git-related commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.