Properly handle the nginx installation dependency #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
josegonzalez
commented
Jan 21, 2019
josegonzalez
commented
- ensure nginx is always installed
- install nginx in the same way for apt-using distros
- do not install software-properties-common or python-software-properties if not needed
- ensure nginx is always installed - install nginx in the same way for apt-using distros - do not install software-properties-common or python-software-properties if not needed
josegonzalez
added a commit
that referenced
this pull request
Jan 22, 2019
# History ## 0.14.3 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.14.3/bootstrap.sh sudo DOKKU_TAG=v0.14.3 bash bootstrap.sh ``` ### Bug Fixes - #3412: @josegonzalez Ensure official golang plugins have correct help output - #3411: @josegonzalez Properly handle the nginx installation dependency - #3406: @josegonzalez Add missing semicolons to app-json script - #3394: @josegonzalez Quiet ps:retire where possible ### New Features - #3410: @josegonzalez Make installs quieter - #3409: @josegonzalez Build golang binaries with higher concurrency - #3408: @josegonzalez Disable container restarts for stopped containers - #3389: @heyarne Remove jQuery from web-based installer ### Documentation - #3407: @tkrugg Fix typo on domain docs ### Tests - #3414: @josegonzalez Test and release changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.