Fix GitLab CI examples #3507
Merged
Fix GitLab CI examples #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitLab CI examples used `$CI_ENVIRONMENT_SLUG` for defining the environment names of the deploy jobs. But this variable is actually the OUTPUT of setting the environment name, thus, it tries to reference itself, but does not exist in that moment. The correct way to set this is to use `$CI_COMMIT_REF_NAME` as based on the documentation of GitLab's dynamic environments.
josegonzalez
added a commit
that referenced
this pull request
Apr 22, 2019
# History ## 0.15.5 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.15.5/bootstrap.sh sudo DOKKU_TAG=v0.15.5 bash bootstrap.sh ``` ### New Features - #3511: @josegonzalez Add json output to config:export ### Documentation - #3510: @josegonzalez Remove SPONSORS doc in favor of OpenCollective - #3509: @Neamar Missing space in markdown formatting - #3507: @renestalder Fix GitLab CI examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitLab CI examples used
$CI_ENVIRONMENT_SLUGfor defining the environment namesof the deploy jobs. But this variable is actually the OUTPUT of setting the environment name,
thus, it tries to reference itself, but does not exist in that moment.
The correct way to set this is to use
$CI_COMMIT_REF_NAMEas based on the documentationof GitLab's dynamic environments.