Clarify resource management for docker-local scheduler #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there can be custom schedulers, including scheduler-specific information on the resource management page can be a disingenuous - the values don't map to kubernetes, for example - and thus we should call out to the scheduler docs (and underlying docker docs) to make the mapping more clear.
|
I opted to point to the docker-local scheduler docs, and also have those docs point off to the official Docker documentation. If the upstream docs don't cut it, I think its best that folks explain there what the docker flags mean, rather than us coming up potentially bad examples. |
josegonzalez
changed the title
josegonzalez
added a commit
that referenced
this pull request
Jan 16, 2020
# History ## 0.19.12 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.19.12/bootstrap.sh sudo DOKKU_TAG=v0.19.12 bash bootstrap.sh ``` ### New Features - #3819: @josegonzalez Allow binding nginx to specific IPv4/IPv6 interfaces - #3818: @josegonzalez Add support for host-mode networking ### Documentation - #3814: @treyssatvincent Use dokku:report to for listing domains - #3809: @josegonzalez Document nginx:show-conf - #3650: @vincelwt Clarify resource management for docker-local scheduler - #3806: @kimar Make default vhost example listen to ipv6 ### Other - #3816: @dependabot-preview[bot] chore(deps): bump handlebars from 4.6.0 to 4.7.1 in /tests/apps/.websocket.disabled - #3815: @dependabot-preview[bot] chore(deps): bump handlebars from 4.5.3 to 4.6.0 in /tests/apps/.websocket.disabled - #3811: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 165 to 166 in /tests/apps/php - #3812: @dependabot-preview[bot] chore(deps): bump jetty-servlet from 9.4.24.v20191120 to 9.4.25.v20191220 in /tests/apps/java - #3810: @dependabot-preview[bot] chore(deps): bump monolog/monolog from 1.25.2 to 1.25.3 in /tests/apps/php - #3808: @dependabot-preview[bot] chore(deps): [security] bump rack from 1.6.11 to 1.6.12 in /tests/apps/ruby - #3807: @dependabot-preview[bot] chore(deps): bump google.golang.org/grpc from 1.25.1 to 1.26.0 in /tests/apps/gogrpc - #3804: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 164 to 165 in /tests/apps/php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
Clarifies a bit the default mapping of
resource:limitforcputo the underlying docker-local scheduler--cpusflag.Should make it clearer what the examples actually do when using
resource:limit --cpu 100.