Fix type-errors in dokku-installer.py #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just setting up a new dokku installation on a clean Ubuntu 18.04.3 LTS droplet and I'm experiencing this same issue. |
josegonzalez
added a commit
that referenced
this pull request
Oct 28, 2019
# History ## 0.19.6 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.19.6/bootstrap.sh sudo DOKKU_TAG=v0.19.6 bash bootstrap.sh ``` ### Other - #3761: @pithyless Fix type-errors in dokku-installer.py - #3759: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 163 to 164 in /tests/apps/php - #3758: @dependabot-preview[bot] chore(deps): bump jetty-servlet from 9.4.21.v20190926 to 9.4.22.v20191022 in /tests/apps/java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the installer on a clean Ubuntu 18.04.3 LTS node and got a 502 Bad Gateway on the initial setup page.
After debugging, identified there were two problems with the
dokku-installer.pyscript (Python 3.6.8).The two changes to the script fix these two type-errors (if I understood the intent of the code correctly).