Properly handle stdout when capturing plugn output #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous output would also include a message like `exit status 1`. This allows us to silence that output and instead only capture that which was return from the subprocess.
josegonzalez
pushed a commit
that referenced
this pull request
Dec 14, 2020
# History ## 0.22.1 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.22.1/bootstrap.sh sudo DOKKU_TAG=v0.22.1 bash bootstrap.sh ``` ### Bug Fixes - #4238: @josegonzalez Ensure dead files are created for docker object retirement - #4239: @josegonzalez Ensure all byte output is trimmed of whitespace - #4228: @Cellane Fix tags:deploy command for images that contain ONBUILD directive - #4233: @josegonzalez Properly parse releease command when there is an entrypoint - #4215: @josegonzalez Implement missing cleanup routines - #4212: @josegonzalez Cleanup docker options during post-delete - #4211: @ml-milan-vit Make the dokku-update command compatible with Dokku 0.22+ ### New Features - #4242: @josegonzalez Remove reference to 'whitelist' - #4220: @josegonzalez Update plugn from 0.5.0 to 0.5.1 - #4241: @josegonzalez Properly handle stdout when capturing plugn output - #4237: @josegonzalez Release dokku-update 0.2.0 - #4225: @znz Accept first pushed branch as deploy-branch ### Documentation - #4236: @josegonzalez Remove note regarding not having an official client - #4234: @josegonzalez Switch to bats --filter for running a single test - #4222: @leopolicastro Fix typo in deployment tasks documentation - #4221: @srr013 Updating readme for clarity on git push step - #4214: @josegonzalez Expand backup and restore documentation - #4213: @josegonzalez Enhance the 'plugin' plugin documentation ### Tests - #4218: @josegonzalez Enable compilation cache ### Other - #4230: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 186 to 187 in /tests/apps/php - #4223: @dependabot-preview[bot] chore(deps): bump jetty-servlet from 9.4.35.v20201120 to 11.0.0 in /tests/apps/java - #4224: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 185 to 186 in /tests/apps/php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous output would also include a message like
exit status 1. This allows us to silence that output and instead only capture that which was return from the subprocess.