Strip trailing slashes in hostname from web installer #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web installer needs work to add proper validation of input, but for now, this change will ensure folks don't accidentally add an extra slash to the global domain. Closes #4106 [ci skip]
josegonzalez
pushed a commit
that referenced
this pull request
Jan 18, 2021
# History ## 0.22.9 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.22.9/bootstrap.sh sudo DOKKU_TAG=v0.22.9 bash bootstrap.sh ``` ### Bug Fixes - #4334: @josegonzalez allow git pushes to apps that already exist but have old names - #4335: @josegonzalez Add error checking to plugin:install and plugin:update - #4338: @josegonzalez Strip trailing slashes in hostname from web installer - #4332: @josegonzalez Correct aws release check in release-plugin script - #4311: @nisseknudsen Allow named volume mounts in regex - #4320: @josegonzalez Hardcode cnb workdir to /workspace ### New Features - #4321: @josegonzalez Add git version to output ### Refactors - #4329: @josegonzalez Standardize apt-get usage ### Documentation - #4323: @stianlik Fix typo in nginx documentation ### Tests - #4331: @josegonzalez Switch to upstream bats-core - #4330: @josegonzalez Switch to using uuidgen for unique app names ### Other - #4325: @WaviestBalloon Updated bootstrap.sh to not show when $DOKKU_TAG equals nothing - #4324: @dependabot-preview[bot] chore(deps): bump socket.io from 3.0.5 to 3.1.0 in /tests/apps/.websocket.disabled - #4319: @josegonzalez Update ruby dependencies in test app - #4312: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 187 to 188 in /tests/apps/php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web installer needs work to add proper validation of input, but for now, this change will ensure folks don't accidentally add an extra slash to the global domain.
Closes #4106