Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial scheduled task implementation #4343

Merged
merged 9 commits into from
Jan 21, 2021

Conversation

josegonzalez
Copy link
Member

@josegonzalez josegonzalez commented Jan 18, 2021

This functionality enables users to manage a global task schedule for the Dokku user that contains all scheduled tasks across all apps. Alternative schedulers can implement scheduled tasks as desired. The docker-local scheduler uses crontab.

TODO:

  • Write tests
  • Re-namespace to scheduler plugin
  • Add commands to enable/disable specific scheduled tasks for an app Changed my mind here, should be that the codebase controls what is happening, and therefore the repository is the best place to add/remove scheduled tasks
  • Add command to list scheduled tasks for an app
  • Add a report command

Refs #4199

plugins/app-json/appjson.go Show resolved Hide resolved
plugins/app-json/appjson.go Show resolved Hide resolved
plugins/app-json/appjson.go Show resolved Hide resolved
plugins/scheduler/subcommands.go Outdated Show resolved Hide resolved
@josegonzalez josegonzalez force-pushed the 4199-scheduled-tasks branch 2 times, most recently from a8da834 to aa628b1 Compare January 19, 2021 00:07
This functionality enables users to manage a global crontab for the Dokku user that contains all scheduled tasks across all apps. Alternative schedulers can implement cron tasks as desired.
- split out run and enter docs into two different sections
- gather all process related docs into one new section
- add scheduled cron task docs
@josegonzalez josegonzalez merged commit 1d8a98e into master Jan 21, 2021
@josegonzalez josegonzalez deleted the 4199-scheduled-tasks branch January 21, 2021 06:31
josegonzalez pushed a commit that referenced this pull request Jan 24, 2021
# History

## 0.23.0

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.23.0/bootstrap.sh
sudo DOKKU_TAG=v0.23.0 bash bootstrap.sh
```

See the [0.23.0 migration guide](/docs/appendices/0.23.0-migration-guide.md) for more information on migrating to 0.23.0.

### Bug Fixes

- #4356: @josegonzalez Do not retag images unnecessarily
- #4355: @josegonzalez Allow underscores in vector schemes
- #4350: @josegonzalez Add missing trigger to events plugin
- #4348: @josegonzalez Correct app-specific shell handling
- #4333: @josegonzalez Drop tmpdir environment variables when not running as dokku user

### New Features

- #4336: @josegonzalez Add ability to manage stacks on an app or global level …
- #4354: @josegonzalez Log all triggers called by golang in trace output
- #4300: @AubreyHewes allow disabling hsts globally and explicitly enable per app
- #4337: @josegonzalez Add logrotation to container log files
- #4318: @josegonzalez Add ability to set client max body size via nginx:set
- #4343: @josegonzalez feat: add initial scheduled task implementation
- #4297: @josegonzalez Add support for cloning/syncing from a remote repository
- #4340: @bjornpost Allow configuring x-forwarded-* proxy headers via nginx:set

### Refactors

- #4349: @josegonzalez Remove need for internal dokku calls

### Documentation

- #4347: @fomojola Add post-deploy webhook to list of community plugins
- #4342: @AubreyHewes Point to current testing docs
- #4341: @josegonzalez Add testing link to contributing.md

### Tests

- #4352: @josegonzalez Add a test for application renames
- #4351: @josegonzalez Set hostname for CI runs
- #4322: @josegonzalez Switch to Github Actions for CI

### Other

- #4353: @josegonzalez Drop unused flag introduced by logs max-size feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants