Simplify tar and zip deploys via git:from-archive #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous tar support lacked the ability to track changes between tarball deploys. Critically, it also failed to be handled correctly when there was _also_ a git deployment done on the app, resulting in odd deployment states depending on the angles of the moon and the sun in the sky. Rather than try to "fix" this through some hokey mechanism, importing the tar file contents into the git repository is preferred, as then the user can refer to the repository for commit history. Additionally, we add support for non-tar files (tar.gz and zip), enabling deployments from systems that do not create tar files, such as Github (their tarball url is a tar.gz file). Finally, this deprecates the tar plugin, and sets it to be removed in the next minor release (in addition to the tags plugin). Closes #3458 Closes #4207
josegonzalez
force-pushed
the
3458-git-from-archive
branch
from
f2755e4
to
5c1a1ba
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
# History ## 0.24.0 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.24.0/bootstrap.sh sudo DOKKU_TAG=v0.24.0 bash bootstrap.sh ``` See the [0.24.0 migration guide](/docs/appendices/0.24.0-migration-guide.md) for more information on migrating to 0.24.0. ### Bug Fixes - #4449: @josegonzalez Gitignore trigger symlink - #4447: @josegonzalez Checkout code to ensure the bump-azure script is available ### New Features - #4453: @josegonzalez Simplify tar and zip deploys via git:from-archive - #4450: @josegonzalez Simplify docker image deploys via git:from-image - #4379: @josegonzalez Allow builders to be detected based on repository contents - #4425: @josegonzalez Implement heroku's postdeploy deployment task - #4424: @josegonzalez Implement git:auth command - #4419: @josegonzalez Add parallelism to certain proxy commands ### Refactors - #4374: @josegonzalez Change exit code when app does not exist ### Documentation - #4451: @josegonzalez Update links to builder documentation to avoid extra rewrite - #4448: @josegonzalez Add documentation for git push to dokku-in-docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tar support lacked the ability to track changes between tarball deploys. Critically, it also failed to be handled correctly when there was also a git deployment done on the app, resulting in odd deployment states depending on the angles of the moon and the sun in the sky.
Rather than try to "fix" this through some hokey mechanism, importing the tar file contents into the git repository is preferred, as then the user can refer to the repository for commit history.
Additionally, we add support for non-tar files (tar.gz and zip), enabling deployments from systems that do not create tar files, such as Github (their tarball url is a tar.gz file).
Finally, this deprecates the tar plugin, and sets it to be removed in the next minor release (in addition to the tags plugin).
Closes #3458
Closes #4207
Note: If this PR is just doc changes, please put [ci skip] in the body that way tests do not run.