-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.31.0 #5947
Merged
Merged
Release 0.31.0 #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
josegonzalez
commented
Jun 17, 2023
•
edited
Loading
edited
- Move herokuish app cache from the filesystem into a docker volume #5495
- Add support for specifying multiple networks on a given app #5891
- Remove Stickler configuration #5976
- Remove all containers and images by label on app destroy #5973
- Standardize on ls subcommand when interacting with the docker binary #5974
- Move all shellcheck disable definitions to .shellcheckrc #5977
- Standardize on shorthand for redirecting all output to /dev/null #5975
- Do not start proxy implementations during server restore if they weren't manually started via the :start command #5979
- Mount the traefik data directory instead of the acme.json file when starting traefik #5985
- Clarify that a branch can be specified when updating a plugin #5987
- Move all port management code to standalone ports plugin #5986
- Skip scaled processes that are missing in the Procfile #5989
- Move crontab writing code to scheduler-docker-local plugin #5988 (includes parallelize code)
- Generate jobs for crontab in parallel #5908
- Add json format output to cron:list command #5990
- Mount the vector data directory instead of the vector file #5992
- Un-deprecate apps and config cli aliases #5993
- Add the ability to execute a cron task on the fly #5991
- Use ports-get plugn trigger for fetching port mappings #6011
- Use ports:report to get the list of port mappings #6012
- Automatically clear the git source-image property when changing deployment methodologies #6014
- Export environment variables during dockerfile builds for use with value-less --build-arg flags #6013
- Move CHECKS file extraction to the beginning of the deploy #6015
- Use ports-clear plugn trigger to manage clearing the port map #6010
- Sort the plugin triggers #6016
- Add application/wasm to nginx.conf.sigil gzip #6007
- Move code that fetches raw tcp ports for dockerfile deploys to ports plugin #6018
- Move code for fetching an available port to the ports plugin #6019
- Deprecate proxy-configure-ports plugin trigger in favor of ports-configure #6017
- Simplify ports-configure codebase #6021
- Migrate the proxy port map from config variable to property system #5995
- Rename port-map property to port #6042
- Write auto-detected port mappings during a deploy #6043
- Inject docker labels when nginx proxy implementation is in use #6057
- Do not write empty values for nginx container labels #6070
- Use an alternative curl request to ensure requests go to the local nginx #6075
- Fix issue where networks weren't being torn down during testing #6074
- Use assert_output_not_exists instead of asserting output is empty string #6076
- Use correct quoting in format template when fetching exposed image ports #6078
- Remove debugging code from builder-dockerfile plugin #6079
- Add assertions to various bats tests #6080
- Use correct namespace for haproxy service state tracking #6081
- Correct assertion for dockerfile builds when a variable is eval'd #6094
- Remove assertion for unconsumed build arguments #6095
- Upgrade vector image from 0.23.x to 0.31.x #6096
- Upgrade caddy image from 2.7 to 2.8 #6097
- Upgrade traefik image from v2.8 to v2.10 #6098
- Provide users the ability to override auto-detected port mappings #6029
- Clean up references in proxy plugins #6099
- Make it possible to specify an alternative base domain for tests #6101
- Add openresty proxy implementation #6082
- Add support for non-web healthchecks via app.json #6100
- Deprecate ARM as a build target #6102
- Timeout docker image builds in CI #6103
- Correctly handle rebase when generating release notes for minor/major releases #6110
- Make heroku-22/jammy the default stack for cnb/herokuish builds #6109
- Remove extra newline in migration docs #6116
aff94a5
to
9fab8c8
Compare
015b94e
to
5762905
Compare
bbf1542
to
4bfbc60
Compare
629781d
to
4f5f2fd
Compare
9897654
to
d4ad8c0
Compare
…volume This simplifies cache referencing and also paves the way for removing more from the app git directory. Refs #1558
52a4bb0
to
ffd2a2e
Compare
Stickler-CI was shutdown in May 2023 - https://stickler-ci.com/shutting-down - and thus we no longer need configuration for it. So long, and thanks for all the fish :)
Previously, we would filter containers and images by name, which could be fail if the app was renamed or no longer was tagged "correctly" due to a rebuild. Now, we filter by label, ensuring an app is completely cleaned up on deletion. Also: - Move docker image cleanup from apps plugin to builder plugin: This isn't where it belongs - images should be cleaned up in a builder plugin (or the builders plugin) and not in the apps plugin, which has nothing to do with docker images anyways. - Remove the code from the scheduler plugin, as that will only do anything if the scheduler is enabled for the app. - Bypass image removal if there are no images to remove - Always delete app containers: The herokuish builder creates intermediate build containers - something that should be refactored - and ideally this gets run in that builder plugin, but keeping the logic here ensures we don't have code duplication. This is otherwise safe as it will be a no-op if there are no containers to clean up.
…binary The ls command is what is referenced in the --help output for the subcommands, so we should just use that everywhere.
This makes standard use of shellcheck work without needing to provide extra configuration anywhere. Also remove use of inline 'shellcheck disable' calls that are already defined in the .shellcheckrc and don't need to be set inline.
Docker no longer outputs any logging for unconsumed build arguments with the switch to buildx.
Previously, we would always set the port mapping during a dockerfile build, making it difficult for users to override mappings. We also only _sometimes_ updated the detected port mapping, further confusing issues when users were migrating from Dockerfile to Buildpacks for builds. Now, we always detect the port mapping during the build process, and only use that detected port mapping if an override is not specified. This greatly simplifies the experience around port mapping, as now a user can create an app, set a port mapping, and that first deploy will respect the port mapping without an additional deploy. The builder always has the best context for what the app should be listening on, and thus we can always specify a "default" port mapping at this stage. Users can override this map as desired later. This change also results in the removal of a ton of internal code that is now centralized in the ports plugin. Closes #4067
ffd2a2e
to
f8ccf52
Compare
When developing Dokku, it is useful to use a real domain to test actual functionality. This is impossible if the domain is hardcoded to dokku.me in testing.
bbba5d0
to
5846301
Compare
This plugin is mostly compatible with the nginx plugin, but runs the proxy within a docker container. Users do not have direct access to add custom openresty configuration at this time, but instead receive the ability to setup automatic ssl on first request via letsencrypt integration.
Add openresty proxy implementation
This change converts existing CHECKS files into a healthchecks key that is understood by 'docker-container-healthchecker'. This tool supports a number of different types of container healthchecks - command, http, uptime - and can perform healthchecks against non-web processes. The use of the old CHECKS file is now deprecated, and will be removed in the next minor version. Users can use the 'docker-container-healthchecker' to convert existing CHECKS files to the new format automatically. Closes #2760
Add support for non-web healthchecks via app.json
AMD64 and ARM64 continue to be supported, but ARM in CI is not currently supported and doesn't get local testing either, so deprecating it now and removing it in the future makes most sense for the project.
Deprecate ARM as a build target
ARM usually takes quite a while to build. If it takes more than ~15 minutes, then it is usually going to fail anyways, so timeout early. AMD64 takes ~3 minutes, and ARM64 appears to take 15 minutes.
feat: timeout docker image builds in CI
…major releases With the integration branch where pull requests are merged prior to a release, we require a rebase every so often to ensure there aren't any issues upon merging to master. Unfortunately, this breaks the link between the original PR and the integration PR, thus causing changelog generation to fail as it depended upon those - now removed - merge request commits. With this change, we introduce usage of milestones in order to track what is getting merged into a release. Milestones are only used for major/minor releases, and all others will fall back to the default git log method.
Correctly handle rebase when generating release notes for minor/major releases
Make heroku-22/jammy the default stack for cnb/herokuish builds
Remove extra newline in migration docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.