Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly use cache volume for herokuish builds #6631

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Correctly use cache volume for herokuish builds #6631

merged 4 commits into from
Feb 25, 2024

Commits on Feb 25, 2024

  1. fix: correctly use cache volume for herokuish builds 

    Rather than try to mount a directory into the container and use a symlink, directly mount the volume in.

Note that this requires deleting the task container prior to continuing in order to ensure the volume isn't still mounted prior to other tasks being executed.
    @josegonzalez
    josegonzalez committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b7788ab View commit details
    Browse the repository at this point in the history

  2. fix: remove reference to cache dir

    @josegonzalez
    josegonzalez committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1c917a4 View commit details
    Browse the repository at this point in the history

  3. fix: remove tests that are no longer applicable

    @josegonzalez
    josegonzalez committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    18c54d3 View commit details
    Browse the repository at this point in the history

  4. fix: update test to fix case where intermediate containers are now im… 

    …mediately removed
    @josegonzalez
    josegonzalez committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c7e1f2d View commit details
    Browse the repository at this point in the history