refactor page saving and introduce COMMON_WIKIPAGE_SAVE #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the saveWikiText() function a little easier to read and moves external edit handling to its own function. Behavior stays the same (tests are unchanged). In addition a new event COMMON_WIKIPAGE_SAVE is introduced that makes intercepting and acting on page saves much easier than possible before. Developers can: * prevent saves by either preventing the default action or overwriting the contentChanged field in a BEFORE hook * enforce saves even when no content changed by overwriting the contentChanged field in a BEFORE hook * Adjust the saved content by modifying the newContent field in a BEFORE hook * Adjust the stored change log information (summary, type, extras) in an AFTER hook * Easily know if a page was deleted, created or edited by inspecting the changeType field * what ever they want before or after a wiki page is saved
|
The inspection completed: 2 new issues |
5 tasks
splitbrain
added a commit
that referenced
this pull request
Feb 24, 2016
refactor page saving and introduce COMMON_WIKIPAGE_SAVE
|
https://www.dokuwiki.org/devel:event:common_wikipage_save looks complete. |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the saveWikiText() function a little easier to read and moves
external edit handling to its own function. Behavior stays the same
(tests are unchanged).
In addition a new event COMMON_WIKIPAGE_SAVE is introduced that makes
intercepting and acting on page saves much easier than possible before.
Developers can:
the contentChanged field in a BEFORE hook
contentChanged field in a BEFORE hook
hook
AFTER hook
changeType field