make reuse of mediamanager popup easier #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we actually want it in this branch ;-) This reverts commit 38a2174.
|
Yeah, this PR contains a revert of a revert commit, because I accidentally pushed this to master 😵 |
5 tasks
This makes sure the provided callback is using alphanumerics only. I'm not sure this is needed, but better safe than sorry.
* master: refactor page saving and introduce COMMON_WIKIPAGE_SAVE
|
The inspection completed: No new issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a mechanism to override what happens when a media item is selected in the media manager popup by providing a callback name in the URL. The default implementation just does what dw_mediamanager.insert did before and calls insertTags()