-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better core search #2286
Better core search #2286
Commits on Mar 19, 2018
-
refactor(Search): refactor html_search into Ui/Search
This commit should be without functional changes.
Configuration menu - View commit details
-
Copy full SHA for 21fcef8 - Browse repository at this point
Copy the full SHA 21fcef8View commit details -
feat(Search): Add search form on results page
Add the search form on the results page itself. This form will be used to add more options to refine the search further.
Configuration menu - View commit details
-
Copy full SHA for 427ed98 - Browse repository at this point
Copy the full SHA 427ed98View commit details
Commits on Mar 20, 2018
-
feat(search): add search assistance for simple queries
This add some search assistance to simple, single-word search queries which may be restricted to a single namespace. Further improvements: * better styling * trigger events for other plugins * set namespaces directly from fulltext search results * some more config options
Configuration menu - View commit details
-
Copy full SHA for bb8ef86 - Browse repository at this point
Copy the full SHA bb8ef86View commit details
Commits on Mar 21, 2018
-
feat(search): trigger event for each result
Add events around each search result, both for the pagename results and the fullpage results. The fullpage results are wrapped in a div for better separation and styling. ( see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl ) These events are intended to provide plugin authors with the ability to hydrate the search results with more information.
Configuration menu - View commit details
-
Copy full SHA for 4eab6f7 - Browse repository at this point
Copy the full SHA 4eab6f7View commit details -
feat(search): trigger event for search form modification
Plugins may want to offer more ways to filter the search results.
Configuration menu - View commit details
-
Copy full SHA for 81a0edd - Browse repository at this point
Copy the full SHA 81a0eddView commit details -
feat: add a simple unparser for parsed search queries
To allow creating links with manipulated versions of the current search query an unparser is necessary. However, the current output of ft_queryParser makes some advanced features hard to detect. Therefore the new ft_queryUnparser_simple cannot handle negated phrases and `OR` searches. It should still cover 98% of search queries.
Configuration menu - View commit details
-
Copy full SHA for 44156e1 - Browse repository at this point
Copy the full SHA 44156e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c924eb - Browse repository at this point
Copy the full SHA 4c924ebView commit details
Commits on Mar 22, 2018
-
refactor: make tpl_seachform use dokuwiki\Form
This makes it easier to read, reason and extend.
Configuration menu - View commit details
-
Copy full SHA for 3c7a332 - Browse repository at this point
Copy the full SHA 3c7a332View commit details -
feat(search): add origin page as parameter
There are several use cases in which knowing the page where a search request originated would be useful. This commit adds a `from` parameter which provides that information.
Configuration menu - View commit details
-
Copy full SHA for cbcc2fa - Browse repository at this point
Copy the full SHA cbcc2faView commit details -
feat(search): add config options to adjust default behavior
This adds two new config options: `search_limit_to_first_ns`: Limit the search to the current X namespaces. When a search is executed from a page within a deeper namespace, the first X namespaces will be added as filter. Possible use case could be with language namespaces to ensure that the default search is initially within the current language. `search_default_fragment_behaviour`: Option to specify the default fragment search behavior
Configuration menu - View commit details
-
Copy full SHA for d09b5b6 - Browse repository at this point
Copy the full SHA d09b5b6View commit details -
feat(search): show search adjustments as links
This simplifies many aspects. However, it still needs much better styling.
Configuration menu - View commit details
-
Copy full SHA for 4d0cb6e - Browse repository at this point
Copy the full SHA 4d0cb6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5bf110 - Browse repository at this point
Copy the full SHA e5bf110View commit details
Commits on Mar 23, 2018
-
fix: readd div with no-class to tpl_searchform
Quick-search positioning and other templates break when removing this tag.
Configuration menu - View commit details
-
Copy full SHA for 3eb2b86 - Browse repository at this point
Copy the full SHA 3eb2b86View commit details -
fix(search): namespace limits must match exactly
This fixes a bug that during a search limited to `@de` would show pages form the namespace `devel` as well (in the fullpage results). Fixes #2285
Configuration menu - View commit details
-
Copy full SHA for de3383c - Browse repository at this point
Copy the full SHA de3383cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a75abf - Browse repository at this point
Copy the full SHA 9a75abfView commit details -
feat(search): filter results by lastmod time
This allows filtering of results by the last modified time. It still needs a custom date entry option, highlighting of the currently selected option (if any) and a better place where the filtering happens.
Configuration menu - View commit details
-
Copy full SHA for bbc1da2 - Browse repository at this point
Copy the full SHA bbc1da2View commit details
Commits on Mar 26, 2018
-
feat(search): use dedicated url-parameter for search query
This way we do not loose the context of the current page. Further, the new id generated from the query before wasn't really that useful (see issue #1124 ). And we can still generate a meaningful link "create a page for your query", if that is considered useful. Further redirects exist for the old urls, so bookmarked searches etc. should mostly keep working.
Configuration menu - View commit details
-
Copy full SHA for d22b78c - Browse repository at this point
Copy the full SHA d22b78cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3cfe85 - Browse repository at this point
Copy the full SHA b3cfe85View commit details -
fix(search): don't truncate namespaces with - and . in pagename-lookup
The regex for the pagename lookup didn't account for `-` and `.` being valid characters for namespaces, which lead to wrong results in the quicksearch and pagename lookup. The full search, which already used the queryParser, showed the correct results. This fixes #1659
Configuration menu - View commit details
-
Copy full SHA for 940f24f - Browse repository at this point
Copy the full SHA 940f24fView commit details -
refactor(search): move filtering by time into _ft_page*
This is the more appropriate place for that functionality, because now it happens inside the default function for the respective pagesearch and pagelookup events and can be properly handled by plugins.
Configuration menu - View commit details
-
Copy full SHA for 1b48999 - Browse repository at this point
Copy the full SHA 1b48999View commit details -
refactor(search): extract simplified SearchState class
Building the new search links is complex and we're going to add another parameter with the new sorting by mtime. Extracting a new class seems like the cleanest way to handle that increasing complexity.
Configuration menu - View commit details
-
Copy full SHA for 18856c5 - Browse repository at this point
Copy the full SHA 18856c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d0e286 - Browse repository at this point
Copy the full SHA 8d0e286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6639a15 - Browse repository at this point
Copy the full SHA 6639a15View commit details -
feat(search): display search tools as lists on click
This functionality is inspired by what other large search engines are doing.
Configuration menu - View commit details
-
Copy full SHA for b005809 - Browse repository at this point
Copy the full SHA b005809View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01c23ba - Browse repository at this point
Copy the full SHA 01c23baView commit details
Commits on Mar 27, 2018
-
feat(search) more nuanced tool deactivation
This gives create control over when a query is too complex for tool support.
Configuration menu - View commit details
-
Copy full SHA for df97724 - Browse repository at this point
Copy the full SHA df97724View commit details -
fix(search): detect irregular fragment query
If the entered query does not cleanly fall into the area of the given options, show the current behavior as "custom".
Configuration menu - View commit details
-
Copy full SHA for c6b5b74 - Browse repository at this point
Copy the full SHA c6b5b74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5facb9b - Browse repository at this point
Copy the full SHA 5facb9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 340f849 - Browse repository at this point
Copy the full SHA 340f849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1265b19 - Browse repository at this point
Copy the full SHA 1265b19View commit details -
feat(search): trigger new event for small search field form
This also renames the event for the search form on the search page. The scheme for naming events that provide the new Form-class as $data is FORM_<formname>_OUTPUT
Configuration menu - View commit details
-
Copy full SHA for 16ece95 - Browse repository at this point
Copy the full SHA 16ece95View commit details -
This removes a lot of reudundant CSS classes in favor of cascading selectors. Styling isn't done, yet this is just a first step. Still to do: * aria labels * styling the toggle mechanism * RTL styling * making sure everything displays correct when no JS is available * translations may be missing * refactoring the rest of search.less to make use of LESS features
Configuration menu - View commit details
-
Copy full SHA for 4bdf82b - Browse repository at this point
Copy the full SHA 4bdf82bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55dc878 - Browse repository at this point
Copy the full SHA 55dc878View commit details -
l10n(search): Add link to create page from query to searchintro
Implements the functionality requested in #1124
Configuration menu - View commit details
-
Copy full SHA for 2ce8aff - Browse repository at this point
Copy the full SHA 2ce8affView commit details -
refactor(search): rewite SearchState to make behavior more obvious
As suggested by @splitbrain SearchState now behaves simliar to the PSR-7 message interfaces.
Configuration menu - View commit details
-
Copy full SHA for 52d4cd4 - Browse repository at this point
Copy the full SHA 52d4cd4View commit details -
refactor(search): provide before/after arguments to search event
This way they can be cleanly influenced by the plugins instead of having to modify global state.
Configuration menu - View commit details
-
Copy full SHA for 3850270 - Browse repository at this point
Copy the full SHA 3850270View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5bd572 - Browse repository at this point
Copy the full SHA c5bd572View commit details -
fix: display "show" item in page menu during search action
Since we no longer change the page during a search, using the "show" menu item to return to the current page makes more sense.
Configuration menu - View commit details
-
Copy full SHA for 220966d - Browse repository at this point
Copy the full SHA 220966dView commit details -
fix(search): don't search for current page if submitting empty form
Pressing enter in the small quick-search-box while it was empty resulted in a search for the current pageid.
Configuration menu - View commit details
-
Copy full SHA for 3286c65 - Browse repository at this point
Copy the full SHA 3286c65View commit details -
feat(Form): add parameter to omit security token in forms
This is useful for anonymously useable forms, like the search.
Configuration menu - View commit details
-
Copy full SHA for 7fa270b - Browse repository at this point
Copy the full SHA 7fa270bView commit details -
Configuration menu - View commit details
-
Copy full SHA for be76738 - Browse repository at this point
Copy the full SHA be76738View commit details
Commits on Mar 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c6070d6 - Browse repository at this point
Copy the full SHA c6070d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc3880 - Browse repository at this point
Copy the full SHA 0fc3880View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d91889 - Browse repository at this point
Copy the full SHA 1d91889View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2171f9c - Browse repository at this point
Copy the full SHA 2171f9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d6156 - Browse repository at this point
Copy the full SHA c2d6156View commit details -
Configuration menu - View commit details
-
Copy full SHA for a00078f - Browse repository at this point
Copy the full SHA a00078fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 826e222 - Browse repository at this point
Copy the full SHA 826e222View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc46ed5 - Browse repository at this point
Copy the full SHA fc46ed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec27794 - Browse repository at this point
Copy the full SHA ec27794View commit details
Commits on Mar 29, 2018
-
refactor: rename dta and dtb parameters
They are now named min and max respectively, which is hopefully less cryptic.
Configuration menu - View commit details
-
Copy full SHA for 422bbbc - Browse repository at this point
Copy the full SHA 422bbbcView commit details