Refactor subscriptions #2759

micgro42 · 2019-04-20T21:08:31Z

decide whether to split up ChangeSubscriptionsDispatcher class into one for pages, media and bulk
PSR-2 fixes in new classes
move old Subscription class to deprecated.php
rewrite use of old subscription code in DokuWiki base

This allows us to rename the snake_case methods and to group them in a more sensible manner.

This splits up and slightly refactors the tests for the refactored subscriptions classes

splitbrain · 2019-04-21T07:33:28Z

LGTM. Splitting the ChangeSubscriptions makes sense to me.

This should better adhere to SRP and simplify things.

This class has been replaced by the classes in the dokuwiki/Subscriptions namespace.

micgro42 added 4 commits April 21, 2019 00:43

♻️ Extract subscription classes for PSR 2

479c05b

This allows us to rename the snake_case methods and to group them in a more sensible manner.

✅ Fix Subscriptions tests

47de339

This splits up and slightly refactors the tests for the refactored subscriptions classes

Automatic code style fixes for subscription classes

9c22b77

♻️ Don't use deprecated subscription methods

75d6649

micgro42 force-pushed the refactorSubscriptions branch from 74035a3 to 75d6649 Compare April 20, 2019 22:51

micgro42 requested a review from splitbrain April 20, 2019 22:51

micgro42 added 2 commits April 22, 2019 21:32

♻️ Split up ChangesSubscriptionSender into multiple classes

704a815

This should better adhere to SRP and simplify things.

🚚 Move Subscription class to deprecated.php

451969a

This class has been replaced by the classes in the dokuwiki/Subscriptions namespace.

splitbrain merged commit b8c09b6 into psr2 May 19, 2019

splitbrain deleted the refactorSubscriptions branch May 19, 2019 08:48

Provide feedback