Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subscriptions #2759

Merged
merged 6 commits into from
May 19, 2019
Merged

Refactor subscriptions #2759

merged 6 commits into from
May 19, 2019

Commits on Apr 20, 2019

  1. ♻️ Extract subscription classes for PSR 2 

    This allows us to rename the snake_case methods and to group them in a
more sensible manner.
    @micgro42
    micgro42 committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    479c05b View commit details
    Browse the repository at this point in the history

  2. ✅ Fix Subscriptions tests 

    This splits up and slightly refactors the tests for the refactored subscriptions classes
    @micgro42
    micgro42 committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    47de339 View commit details
    Browse the repository at this point in the history

  3. Automatic code style fixes for subscription classes

    @micgro42
    micgro42 committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    9c22b77 View commit details
    Browse the repository at this point in the history

  4. ♻️ Don't use deprecated subscription methods

    @micgro42
    micgro42 committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    75d6649 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2019

  1. ♻️ Split up ChangesSubscriptionSender into multiple classes 

    This should better adhere to SRP and simplify things.
    @micgro42
    micgro42 committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    704a815 View commit details
    Browse the repository at this point in the history

  2. 🚚 Move Subscription class to deprecated.php 

    This class has been replaced by the classes in the
dokuwiki/Subscriptions namespace.
    @micgro42
    micgro42 committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    451969a View commit details
    Browse the repository at this point in the history