change Revert permission to EDIT from manager #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check. Thank you @Klap-in for pointing this out.
|
The initial reasoning for showing the buttons to managers only was to make revert wars a little bit more tedious for normal users. I don't know if it is a problem anyone would actually have. So the question is: is this a usability improvement or a potential abuse increase. I guess we have two votes for UX improvement by @phy25 and @Klap-in. I am unsure. So if nobody objects, I guess we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.
Thank you @Klap-in for pointing this out.