Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow revert action for logged in users only #3346

Merged
merged 2 commits into from Nov 25, 2020
Merged

Allow revert action for logged in users only #3346

merged 2 commits into from Nov 25, 2020

Conversation

splitbrain
Copy link
Collaborator

Since #2995 we have reports of bots reverting wiki pages by ignoring the rel=nofollow attribute on the menu item:

https://forum.dokuwiki.org/d/18227-crawler-keeps-restoring-old-revisions-of-all-articles
https://forum.dokuwiki.org/d/18496-i-am-receiving-random-reverts-from-some-kind-of-bot

This changes the functionality to be available to logged in users only. This should prevent accidental reverts by bots on open wikis.

This should prevent accidental reverts by bots on open wikis
@Klap-in
Copy link
Collaborator

Klap-in commented Nov 20, 2020

Looks logic, however not tested.

Copy link
Collaborator

@phy25 phy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term this should probably be put behind a POST form request rather than a regular GET request, but the current fix should be fine.

inc/Menu/Item/Revert.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants