Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resubmitting bidi and RTL support with lint fixs #103

Merged
merged 17 commits into from
Jul 26, 2018
Merged

resubmitting bidi and RTL support with lint fixs #103

merged 17 commits into from
Jul 26, 2018

Conversation

amitm02
Copy link
Contributor

@amitm02 amitm02 commented Jul 25, 2018

No description provided.

@amitm02 amitm02 changed the title resubmitting bidi and RTL support with lint fixe resubmitting bidi and RTL support with lint fixs Jul 25, 2018
@amitm02
Copy link
Contributor Author

amitm02 commented Jul 25, 2018 •
edited
Loading

I've also added the following:

  1. Support for size for complex fonts (e.g hebrew, arabic). it mostly means adding the <w:szCs>
    http://officeopenxml.com/WPtextFormatting.php
  2. Support for horizontal alignments for RTL languages. it mostly means updating the <w:jc> to accept "start" and "end".
    http://officeopenxml.com/WPalignment.php

@dolanmiu
Copy link
Owner

can you write a demo in the /demo folder to showcase this feature?

@amitm02
Copy link
Contributor Author

amitm02 commented Jul 26, 2018

done.

@dolanmiu
Copy link
Owner

Perfect :)

@dolanmiu dolanmiu merged commit 763fa62 into dolanmiu:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amitm02 @dolanmiu