Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#933 Discriminated union for frame alignment #2477

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

dolanmiu
Copy link
Owner

@dolanmiu dolanmiu commented Dec 25, 2023

@anti-the-social I believe I have found a fix for this

Essentially, you can only have either position or alignment, but not both.

I have updated TypeScript definitions to prevent people from doing that, but it would be a breaking change

Need to add a new type attribute to the frame properties.

Let me know what you think?

Fixes #933

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86bdf3e) 99.96% compared to head (e358216) 99.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2477   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         270      270           
  Lines       13132    13175   +43     
  Branches     1312     1311    -1     
=======================================
+ Hits        13128    13171   +43     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolanmiu dolanmiu merged commit b8f9755 into master Dec 29, 2023
9 checks passed
@dolanmiu dolanmiu deleted the feature/fix-text-frame branch December 29, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frame alignment doesn't seem to work
1 participant