Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image methods #89

Merged
merged 12 commits into from
Aug 3, 2018
Merged

Image methods #89

merged 12 commits into from
Aug 3, 2018

Conversation

dolanmiu
Copy link
Owner

@dolanmiu dolanmiu commented Jul 1, 2018

Two main issues

There needs to be a createImageWithBuffer method to close #74

This is sufficient IMO:

Buffer.from(base64String, 'base64`);

There needs to be a createImage method which does not add it into the file by default to close #82

@madarche madarche mentioned this pull request Jul 5, 2018
Closed
@dolanmiu dolanmiu merged commit b7a4ca9 into master Aug 3, 2018
@dolanmiu dolanmiu deleted the feat/base64-image branch August 9, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table cell with image Image from Data URI base64
1 participant
@dolanmiu