Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Call Pinging is now optional #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

woksin
Copy link
Contributor

@woksin woksin commented Feb 20, 2023

Summary

Makes it possible for the Runtime to not have to send any pings to the SDK for reverse call streams by having that be the default unless PingInterval is explicitly configured. This is done in a way that should be compatible with older Runtimes, but the newest Runtime versions should have a slightly more optimized path for these non-pinging reverse call connections.

Changed

  • When PingInterval is not explicitly configured the reverse calls will not do any ping-ponging anymore

… no pinging is necessary unless the PingInterval is explicitly configured.
@woksin woksin added the patch label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant