Event source concept #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakhog
reviewed
Oct 5, 2021
| @@ -193,7 +193,7 @@ export class EventStore extends IEventStore { | |||
| return new CommittedAggregateEvents(eventSourceId, aggregateRootId, ...convertedEvents); | |||
| } | |||
|
|
|||
| private toUncommittedEvent(content: any, eventSourceId: EventSourceId | Guid | string, eventTypeOrId?: EventType | EventTypeId | Guid | string, isPublic = false): UncommittedEvent { | |||
| private toUncommittedEvent(content: any, eventSourceId: EventSourceId | string, eventTypeOrId?: EventType | EventTypeId | Guid | string, isPublic = false): UncommittedEvent { | |||
There was a problem hiding this comment.
Let's bring the Guid conversions back until we get the poll data :)
| */ | ||
| fromProducerPartition(partitionId: PartitionId | Guid | string): SubscriptionBuilderForProducerPartition { | ||
| fromProducerPartition(partitionId: PartitionId | string): SubscriptionBuilderForProducerPartition { |
| @@ -13,9 +13,9 @@ export class PartitionedFilterResult { | |||
| /** | |||
| * Initializes a new instance of {@link PartitionedFilterResult}. | |||
| * @param {boolean} shouldInclude Tells whether or not the event should be included. | |||
| * @param {PartitionId | Guid | string} partitionId Tells which partition the event should be partitioned into. | |||
| * @param {PartitionId | string} partitionId Tells which partition the event should be partitioned into. | |||
| @@ -31,8 +31,8 @@ export class EventSourceId extends ConceptAs<Guid, '@dolittle/sdk.events.EventSo | |||
| * @param {EventSourceId | Guid | string)} id | |||
| * @returns {EventSourceId} | |||
| */ | |||
| static from(id: EventSourceId | Guid | string): EventSourceId { | |||
| static from(id: EventSourceId | string): EventSourceId { | |||
Comment on lines
+61
to
+63
| commit(event: any, eventSourceId: EventSourceId | string, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitEventsResult>; | ||
| commit(eventOrEvents: UncommittedEvent | UncommittedEvent[], cancellation?: Cancellation): Promise<CommitEventsResult>; | ||
| commit(eventOrEvents: any, eventSourceIdOrCancellation?: EventSourceId | Guid | string | Cancellation, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitEventsResult> { | ||
| commit(eventOrEvents: any, eventSourceIdOrCancellation?: EventSourceId | string | Cancellation, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitEventsResult> { |
| return this.commitInternal([this.toUncommittedEvent(eventOrEvents, eventSourceId, eventType, false)], cancellation); | ||
| } | ||
|
|
||
| /** @inheritdoc */ | ||
| commitPublic(event: any, eventSourceId: EventSourceId | Guid | string, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitEventsResult> { | ||
| commitPublic(event: any, eventSourceId: EventSourceId | string, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitEventsResult> { |
Comment on lines
+79
to
+81
| commitForAggregate(event: any, eventSourceId: EventSourceId | string, aggregateRootId: AggregateRootId, expectedAggregateRootVersion: AggregateRootVersion, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitAggregateEventsResult>; | ||
| commitForAggregate(events: UncommittedAggregateEvents, cancellation?: Cancellation): Promise<CommitAggregateEventsResult>; | ||
| commitForAggregate(eventOrEvents: any, eventSourceIdOrCancellation?: EventSourceId | Guid | string | Cancellation, aggregateRootId?: AggregateRootId, expectedAggregateRootVersion?: AggregateRootVersion, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitAggregateEventsResult> { | ||
| commitForAggregate(eventOrEvents: any, eventSourceIdOrCancellation?: EventSourceId | string | Cancellation, aggregateRootId?: AggregateRootId, expectedAggregateRootVersion?: AggregateRootVersion, eventType?: EventType | EventTypeId | Guid | string, cancellation?: Cancellation): Promise<CommitAggregateEventsResult> { |
|
Merging this in as I've said that I will fix the SDK that is in the wrong :) |
jakhog
added a commit
that referenced
this pull request
Oct 13, 2021
…ing Contracts v6.0.0, and fix little Embedding bug (#61) * Add eventsource prerelease branch * Event source concept (#62) * Update references to contracts * Change partition and event source id to be string instead of guid and fix all build errors * "Update packages and workspace dependencies to 18.0.0-eventsource.0" * Revert Guid types for event source id and partition id (#63) * "Update packages and workspace dependencies to 18.0.0-eventsource.1" * Upgrade contracts to released 6.0.0 (#64) * Upgrade to released 6.0.0 contracts * Fix references to event types * "Update packages and workspace dependencies to 18.0.0-eventsource.2" * Fix a little non breaking space * Fix some small typing issues. * Fix bug when returning multiple events from an embedding update/delete. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jakob Høgenes <1014990+jakhog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update to new contracts that changes partition and event source id to be a string instead of a guid. Fix all build errors that