-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore non postmate message during handshake #35
Conversation
@yowainwright @jakiestfu Not sure if you want the build file added in the PR. The minor dep changes are due to some bit-rot with rollup (lemmabit/rollup-stream#19) and a missing babel dep. I'm not sure why build changed the files size by a kb for my condition. Let me know if you'd like anything revised here. |
Would you mind doing a little investigating with regards to the additional |
Hey, we really need this pull request to be merged. How can we help? |
@eyalcohen4 the only weird thing was the full kb increase in size of the compiled file (or at least the size that was published to the readme). Not sure what to do there. There's nothing other than |
@jakiestfu after a little research I think it's related to the |
@dboskovic I think a pr that was merged recently should help rather than hurt. Could you rebase please? 🙏 |
done! |
@dboskovic please let me know if all is good! Thanks for your patience and time. 🙏 |
If a message is received that does not have a postmate payload, it will break the handshake. This is likely the cause of #29 and #31. It's difficult to add a test for this since it only fails if the message happens exactly in between the handshake.
Below is an example of the handshake failing due to a
webpackOk
event.