fix: ensure urls with different origins are not rendered as local react-router-dom Links #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majew7
force-pushed
the
fix-incorrect-render-bug
branch
from
54a6258
to
b6a1056
Compare
majew7
changed the title
jakiestfu
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
isSameOriginAsCurrentPage()removeOriginFromUrl()MatchFactoryalways identifies a non-match when the origins are different. And ensure origin is not present when renderingdata-safelink-type="link"Bug Revealed
Avoids incorrect rendering of
data-safelink-type="link"when it shouldn't be, but rather simple anchor.See PHX-570.
See screenshot: