Use spaces option if boolean is provided

[mattsacks]

When setting the option spaces to false, it would be ignored due to the default being true.

This PR checks to see if a boolean option is provided for spaces and uses that before defaulting to true.

[yowainwright]

I might be missing something...but the sentence provided above and the pr logic are incorrect.

Thanks for taking the time to review the code and submit a PR!

[mattsacks]

Hey @yowainwright, you're right! I goofed on the ternary syntax 🤦‍♂️

As of now, if opts.spaces is set to false (or any falsy value), it would always be ignored even if we wanted spaces to be false. With the provided fix, if opts.spaces is a boolean, it'll respect whatever value was set. Otherwise, it'll default to true.

Let me know if you'd like me to re-submit the PR with the updated code.

[yowainwright]

The code that is there is tested and appears to be working as expected.

If you would like to take the perceived issue to code editing tool, here's a codepen with spaces set to false.

[mattsacks]

@yowainwright yep! So there, it looks like it's truncating within the word whereas the desired behavior by setting opts.spaces = false would be to split between words. When I changed line 82 between false and true, I didn't actually see any difference rendered (the original issue my PR attempts to fix).

If you check out this codepen with the applied fix, you can see that switching between spaces: false and spaces: true will change where truncation happens (i.e, after the word food and within the word truck respectively).

[yowainwright]

In the Codepen example that was shared above, non-spaced languages are no longer getting truncated.

[mattsacks]

@yowainwright Yep! That's because there's nothing in the code to .split(' ') on (called when opts.spaces === false). So I actually think that's working as intended there?

[yowainwright]

@mattsacks darn it! Thank you for taking the time to continually explain this issue.

You are 100% right! This issue was introduced a while ago too. 😩

Do you still want to provide the pr/fix?

[mattsacks]

@yowainwright I’d love to!

By re-opening this PR, it looks like it got my update for the proper ternary syntax. Is there anything else you need before this can be merged?

[yowainwright]

@mattsacks if you'd like to provide a patch version bump in package.json to 2.2.1 and then build (npm run build), you're more than welcome to!

Other wise, this is prefect. Thanks again! ...And sorry it took, me a bit see the bug.

[mattsacks]

@yowainwright more than happy to, I’ll get that up for you in just a bit.

And no prob! I’m glad we’re able to get this fixed 🙏

[mattsacks]

@yowainwright all set!

[yowainwright]

🚢