Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #20

Closed
5 of 6 tasks
jonathanong opened this issue Jun 16, 2017 · 0 comments · Fixed by #21
Closed
5 of 6 tasks

refactor #20

jonathanong opened this issue Jun 16, 2017 · 0 comments · Fixed by #21

Comments

@jonathanong
Copy link
Contributor

jonathanong commented Jun 16, 2017

  • separate utilities to separate files
    • should be fine to use if we do a UMD build
  • remove on body ready logic
    • this should be handled by the application
    • unnecessary if we load the script tags in the body
    • alternatively, we can just add classes to the html element
  • remove response
  • remove stores, default to memory
    • easier to test when we don't have to deal with localStorage
    • NOTE: NO DEFAULT
  • tests – run on JSDOM so it's easier
  • consider removing bower and only support npm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant