-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Android: Create separate InvertedCheckBoxSetting and PercentSliderSet…
…ting classes This way we don't have to hardcode any keys inside the classes.
- Loading branch information
Showing
5 changed files
with
63 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 3 additions & 16 deletions
19
.../main/java/org/dolphinemu/dolphinemu/features/settings/model/view/FloatSliderSetting.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
.../java/org/dolphinemu/dolphinemu/features/settings/model/view/InvertedCheckBoxSetting.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package org.dolphinemu.dolphinemu.features.settings.model.view; | ||
|
||
import org.dolphinemu.dolphinemu.features.settings.model.Settings; | ||
import org.dolphinemu.dolphinemu.features.settings.utils.SettingsFile; | ||
|
||
public final class InvertedCheckBoxSetting extends CheckBoxSetting | ||
{ | ||
public InvertedCheckBoxSetting(String file, String section, String key, int titleId, | ||
int descriptionId, boolean defaultValue) | ||
{ | ||
super(file, section, key, titleId, descriptionId, !defaultValue); | ||
} | ||
|
||
@Override | ||
public boolean isChecked(Settings settings) | ||
{ | ||
return !settings.getSection(getFile(), getSection()).getBoolean(getKey(), mDefaultValue); | ||
} | ||
|
||
@Override | ||
public void setChecked(Settings settings, boolean checked) | ||
{ | ||
settings.getSection(getFile(), getSection()).setBoolean(getKey(), !checked); | ||
} | ||
} |
25 changes: 25 additions & 0 deletions
25
...ain/java/org/dolphinemu/dolphinemu/features/settings/model/view/PercentSliderSetting.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package org.dolphinemu.dolphinemu.features.settings.model.view; | ||
|
||
import org.dolphinemu.dolphinemu.features.settings.model.Settings; | ||
|
||
public final class PercentSliderSetting extends FloatSliderSetting | ||
{ | ||
public PercentSliderSetting(String file, String section, String key, int titleId, | ||
int descriptionId, int max, String units, float defaultValue) | ||
{ | ||
super(file, section, key, titleId, descriptionId, max, units, defaultValue / 100); | ||
} | ||
|
||
@Override | ||
public int getSelectedValue(Settings settings) | ||
{ | ||
float value = settings.getSection(getFile(), getSection()).getFloat(getKey(), mDefaultValue); | ||
return Math.round(value * 100); | ||
} | ||
|
||
@Override | ||
public void setSelectedValue(Settings settings, float selection) | ||
{ | ||
settings.getSection(getFile(), getSection()).setFloat(getKey(), selection / 100); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters