Skip to content

Commit

Permalink
Qt/MappingNumeric: Calculate values properly
Browse files Browse the repository at this point in the history
  • Loading branch information
spycrab committed Apr 28, 2018
1 parent cf1adfb commit 1fb188a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Source/Core/DolphinQt2/Config/Mapping/MappingNumeric.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "InputCommon/ControllerEmu/Setting/NumericSetting.h"

MappingNumeric::MappingNumeric(MappingWidget* widget, ControllerEmu::NumericSetting* setting)
: m_parent(widget), m_setting(setting), m_range(setting->m_high - setting->m_low)
: m_parent(widget), m_setting(setting)
{
setRange(setting->m_low, setting->m_high);
Update();
Expand All @@ -19,7 +19,7 @@ void MappingNumeric::Connect()
{
connect(this, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), this,
[this](int value) {
m_setting->SetValue(static_cast<double>(value - m_setting->m_low) / m_range);
m_setting->SetValue(static_cast<double>(value) / 100);
m_parent->SaveSettings();
});
}
Expand All @@ -33,5 +33,5 @@ void MappingNumeric::Clear()

void MappingNumeric::Update()
{
setValue(m_setting->m_low + m_setting->GetValue() * m_range);
setValue(m_setting->GetValue() * 100);
}
1 change: 0 additions & 1 deletion Source/Core/DolphinQt2/Config/Mapping/MappingNumeric.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,4 @@ class MappingNumeric : public QSpinBox

MappingWidget* m_parent;
ControllerEmu::NumericSetting* m_setting;
double m_range;
};

0 comments on commit 1fb188a

Please sign in to comment.