Skip to content

Commit

Permalink
Merge pull request #288 from magumagu/remove-hid2-panicalert
Browse files Browse the repository at this point in the history
Interpreter: don't PanicAlert on write to SPR_HID2.
  • Loading branch information
delroth committed Apr 19, 2014
2 parents 8109163 + 002fb0b commit 8a5c0b3
Showing 1 changed file with 4 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -293,28 +293,10 @@ void Interpreter::mtspr(UGeckoInstruction _inst)
}
break;
case SPR_HID2: // HID2
{
UReg_HID2 old_hid2;
old_hid2.Hex = oldValue;

//if (HID2.LCE && !old_hid2.LCE)
// PanicAlert("Locked cache enabled!");

if (HID2.PSE == 0)
PanicAlert("WARNING: PSE (paired single enable) in HID2 was unset");

// bool WriteGatherPipeEnable = (bool)HID2.WPE; //TODO?
// bool LockedCacheEnable = (bool)HID2.LCE;
// int DMAQueueLength = HID2.DMAQL; // Ignore - our DMA:s are instantaneous
// bool PairedSingleEnable = HID2.PSE;
// bool QuantizeEnable = HID2.LSQE;
//TODO(ector): Protect LC memory if LCE is false.
//TODO(ector): Honor PSE.

//_assert_msg_(POWERPC, WriteGatherPipeEnable, "Write gather pipe not enabled!");
//if ((HID2.PSE == 0))
// MessageBox(nullptr, "PSE in HID2 is set", "Warning", MB_OK);
}
// TODO: generate illegal instruction for paired inst if PSE or LSQE
// not set.
// TODO: disable write gather pipe if WPE not set
// TODO: emulate locked cache and DMA bits.
break;

case SPR_WPAR:
Expand Down

0 comments on commit 8a5c0b3

Please sign in to comment.