Merge pull request #8693 from howard0su/warning_xinpu

InputCommon: cleanup warnings of -Wclass-memaccess
dolphin-emu · Mar 23, 2020 · a6d1fe5 · a6d1fe5
2 parents 6fab099 + 997cfa4
commit a6d1fe5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/Source/Core/InputCommon/ControllerInterface/Xlib/XInput2.cpp b/Source/Core/InputCommon/ControllerInterface/Xlib/XInput2.cpp
@@ -131,8 +131,6 @@ void KeyboardMouse::SelectEventsForDevice(Window window, XIEventMask* mask, int
 KeyboardMouse::KeyboardMouse(Window window, int opcode, int pointer, int keyboard)
     : m_window(window), xi_opcode(opcode), pointer_deviceid(pointer), keyboard_deviceid(keyboard)
 {
-  memset(&m_state, 0, sizeof(m_state));
-
   // The cool thing about each KeyboardMouse object having its own Display
   // is that each one gets its own separate copy of the X11 event stream,
   // which it can individually filter to get just the events it's interested

diff --git a/Source/Core/InputCommon/ControllerInterface/Xlib/XInput2.h b/Source/Core/InputCommon/ControllerInterface/Xlib/XInput2.h
@@ -105,7 +105,7 @@ class KeyboardMouse : public Core::Device
 private:
   Window m_window;
   Display* m_display;
-  State m_state;
+  State m_state{};
   int xi_opcode;
   const int pointer_deviceid, keyboard_deviceid;
   std::string name;