Skip to content

Commit

Permalink
Android: Consistent TODO formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
Ebola16 committed May 9, 2020
1 parent 74b2410 commit c8aa077
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ private void browse()

private void tryPlay(AppLinkHelper.PlayAction action)
{
// TODO: This approach of getting the game from the game file cache without rescanning
// the library means that we can fail to launch games if the cache file has been deleted.
// TODO: This approach of getting the game from the game file cache without rescanning the
// library means that we can fail to launch games if the cache file has been deleted.

GameFile game = GameFileCacheService.getGameFileByGameId(action.getGameId());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ protected void onCreate(Bundle savedInstanceState)

updateOrientation();

// TODO: The accurate way to find out which console we're emulating is to
// first launch emulation and then ask the core which console we're emulating
// TODO: The accurate way to find out which console we're emulating is to first
// launch emulation and then ask the core which console we're emulating
sIsGameCubeGame = Platform.fromNativeInt(mPlatform) == Platform.GAMECUBE;
mDeviceHasTouchScreen = getPackageManager().hasSystemFeature("android.hardware.touchscreen");
mMotionListener = new MotionListener(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class PlatformPagerAdapter extends FragmentPagerAdapter
{
R.drawable.ic_gamecube,
R.drawable.ic_wii,
R.drawable.ic_folder // WiiWare TODO Have an icon here.
R.drawable.ic_folder
};

public PlatformPagerAdapter(FragmentManager fm, Context context)
Expand All @@ -49,8 +49,8 @@ public CharSequence getPageTitle(int position)
{
// Hax from https://guides.codepath.com/android/Google-Play-Style-Tabs-using-TabLayout#design-support-library
// Apparently a workaround for TabLayout not supporting icons.
// TODO This workaround will eventually not be necessary; switch to more legit methods when that is the case
// TODO Also remove additional hax from styles.xml
// TODO: This workaround will eventually not be necessary; switch to more legit methods when that is the case
// TODO: Also remove additional hax from styles.xml
Drawable drawable = mContext.getResources().getDrawable(TAB_ICONS[position]);
drawable.setBounds(0, 0, drawable.getIntrinsicWidth(), drawable.getIntrinsicHeight());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent result)
}

// TODO: After result of FilePicker, duplicate SettingsActivity appears.
// Finish to avoid this. Is there a better method?
// Finish to avoid this. Is there a better method?
finish();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ private void addAdvancedSettings(ArrayList<SettingsItem> sl)
overclock = coreSection.getSetting(SettingsFile.KEY_OVERCLOCK_PERCENT);

// TODO: Having different emuCoresEntries/emuCoresValues for each architecture is annoying.
// The proper solution would be to have one emuCoresEntries and one emuCoresValues
// and exclude the values that aren't present in PowerPC::AvailableCPUCores().
// The proper solution would be to have one emuCoresEntries and one emuCoresValues
// and exclude the values that aren't present in PowerPC::AvailableCPUCores().
int defaultCpuCore = NativeLibrary.DefaultCPUCore();
int emuCoresEntries;
int emuCoresValues;
Expand Down Expand Up @@ -446,7 +446,7 @@ private void addGcPadSettings(ArrayList<SettingsItem> sl)
{
if (mGameID.equals(""))
{
// TODO This controller_0 + i business is quite the hack. It should work, but only if the definitions are kept together and in order.
// TODO: This controller_0 + i business is quite the hack. It should work, but only if the definitions are kept together and in order.
Setting gcPadSetting = mSettings.getSection(Settings.SECTION_INI_CORE)
.getSetting(SettingsFile.KEY_GCPAD_TYPE + i);
sl.add(new SingleChoiceSetting(SettingsFile.KEY_GCPAD_TYPE + i, Settings.SECTION_INI_CORE,
Expand All @@ -468,7 +468,7 @@ private void addWiimoteSettings(ArrayList<SettingsItem> sl)
{
for (int i = 0; i < 4; i++)
{
// TODO This wiimote_0 + i business is quite the hack. It should work, but only if the definitions are kept together and in order.
// TODO: This wiimote_0 + i business is quite the hack. It should work, but only if the definitions are kept together and in order.
if (mGameID.equals(""))
{
Setting wiimoteSetting = mSettings.getSection(Settings.SECTION_WIIMOTE + (i + 1))
Expand Down

0 comments on commit c8aa077

Please sign in to comment.