NANDImporter: Various improvements and cleanup #10322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starsam80
force-pushed
the
nand
branch
2 times, most recently
from
73af936
to
7c95c73
Compare
JosJuice
reviewed
Dec 30, 2021
Warepire
reviewed
Dec 30, 2021
lioncash
reviewed
Dec 31, 2021
Starsam80
force-pushed
the
nand
branch
2 times, most recently
from
398286b
to
648f8eb
Compare
|
Rebased and fixed what would have caused a build error on newer versions of fmt. |
Pokechu22
reviewed
Mar 1, 2022
| return false; | ||
| } | ||
|
|
||
| INFO_LOG_FMT(DISCIO, "Using superblock version {:#x}", m_superblock->version); |
There was a problem hiding this comment.
It might still be useful to log the position/index for the superblock.
There was a problem hiding this comment.
I don't think so. I think anybody that needs that information could easily find it with just the version that is printed and comparing it to the previous logs. Feel free to correct me if you think otherwise
There was a problem hiding this comment.
Ah, true, each one is logged beforehand, and that is definitely enough information as long as the version is unique (and if it's not unique, it's still enough information based on the code)
`uid` is a u32, not a u16. Also, everything is big endian, so we can simplify the code a little bit.
It also simplifies the code flow, as it no longer goes backwards through the filesystem chain.
Create a struct describing the superblock layout and use it directly without needing to specify offsets and such.
There is no need to constantly reset the key for every file entry.
Pokechu22
approved these changes
Mar 2, 2022
leoetlino
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of fixes of things I've noticed over the years. There are still a few things I would like to fix, but I figured this would be a good starting point before I make any bigger changes. Future changes include keeping the FST metadata intact (
fst.bin) and some integration with DolphinTool.I've tried to keep each commit separate and reviewable, but I can squash it into a single one if that's preferred for small changes like this.